Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tooltip truncated #151

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix/tooltip truncated #151

merged 2 commits into from
May 16, 2024

Conversation

bmlancien
Copy link
Contributor

Hi @nesnoj, I added tooltip placements so they shouldn't get truncated at least on the sides

  • move the layer tooltips to the left
  • move the other tooltips to the right

I also increased the width to 32rem. Trying to change the variables directly on the vendor file from Bootstrap will not work (I locally didn't see that you tried to change the width).

Is this working this way for you?

close #150

@bmlancien bmlancien requested a review from nesnoj May 16, 2024 13:02
@bmlancien bmlancien self-assigned this May 16, 2024
@bmlancien
Copy link
Contributor Author

I actually just saw that the dropdown info texts from the side panel on step 2 and 5 are in the title attributes of the info icon image. I guess they need to be added to tooltips instead. Right now the tooltip text displays "Keine Auswahl".

Copy link
Contributor

@nesnoj nesnoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - very nice, thx!

(I locally didn't see that you tried to change the width).

I did this in a different branch - don't worry, I'll use your value on merge.

@nesnoj nesnoj merged commit 2164c1b into dev May 16, 2024
1 check passed
@nesnoj nesnoj deleted the fix/tooltip-truncated branch May 16, 2024 15:24
@nesnoj
Copy link
Contributor

nesnoj commented May 16, 2024

@bmlancien Is there a reason you did not adjust the width here (where I did it)

$tooltip-max-width: 300px !default;

but here?

@bmlancien
Copy link
Contributor Author

Yes, doing this directly in the vendor is not recommended. If we update the Bootstrap version, it will override the values. And for clarity it is better to separate overwritten variable from the values from the original library and to add the custom overwritten variables to our custom code.

@nesnoj
Copy link
Contributor

nesnoj commented May 16, 2024

Yes, doing this directly in the vendor is not recommended. If we update the Bootstrap version, it will override the values. And for clarity it is better to separate overwritten variable from the values from the original library and to add the custom overwritten variables to our custom code.

Oh, sure, I missed the "bootstrap" in the path..

nesnoj added a commit that referenced this pull request May 22, 2024
was dropped during merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip layout and style
2 participants