-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/tooltip truncated #151
Conversation
I actually just saw that the dropdown info texts from the side panel on step 2 and 5 are in the title attributes of the info icon image. I guess they need to be added to tooltips instead. Right now the tooltip text displays "Keine Auswahl". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - very nice, thx!
(I locally didn't see that you tried to change the width).
I did this in a different branch - don't worry, I'll use your value on merge.
@bmlancien Is there a reason you did not adjust the width here (where I did it)
but here?
|
Yes, doing this directly in the vendor is not recommended. If we update the Bootstrap version, it will override the values. And for clarity it is better to separate overwritten variable from the values from the original library and to add the custom overwritten variables to our custom code. |
Oh, sure, I missed the "bootstrap" in the path.. |
Hi @nesnoj, I added tooltip placements so they shouldn't get truncated at least on the sides
I also increased the width to 32rem. Trying to change the variables directly on the vendor file from Bootstrap will not work (I locally didn't see that you tried to change the width).
Is this working this way for you?
close #150